Use default in TypeVar so Series defaults to Series[Any], and Index to Index[Any]
#1232
Conversation
MarcoGorelli
force-pushed
the
typevar-default
branch
3 times, most recently
from
1a6dbd7 to
f63956a
Compare
MarcoGorelli
changed the title
default in TypeVar so Series defaults to Series[Any], and Index to Index[Any]default in TypeVar so Series defaults to Series[Any], and Index to Index[Any]
|
I'm fine with this. Need to run |
|
cool, thanks! there's a couple of test failures I haven't figured out, will investigate |
MarcoGorelli
force-pushed
the
typevar-default
branch
from
b0d5713 to
e67aaa9
Compare
| @@ -168,7 +168,7 @@ class SeriesGroupBy(GroupBy[Series[S1]], Generic[S1, ByT]): | |||
| self, | |||
| ) -> Iterator[tuple[ByT, Series[S1]]]: ... | |||
|
|
|||
| _TT = TypeVar("_TT", bound=Literal[True, False]) | |||
| _TT = TypeVar("_TT", bound=Literal[True, False], default=Literal[True]) | |||
There was a problem hiding this comment.
I'm a bit surprised that you didn't have to change the import of TypeVar to come from typing_extensions here since you are using the default feature.
|
i think there might be an issue with mypy here, have reported python/mypy#19182 |
tests/test_frame.py
Outdated
| ), | ||
| pd.DataFrame, | ||
| ) | ||
| check( | ||
| assert_type( | ||
| df_multi_level_cols2.stack([0, 1]), | ||
| Union[pd.DataFrame, "pd.Series[Any]"], | ||
| Union[pd.DataFrame, "pd.Series"], |
There was a problem hiding this comment.
Any of the places where we used to have "pd.Series[Any]" that you changed to "pd.Series" can have the quotes removed. The quotes were there because of the [Any] part.
MarcoGorelli
changed the title
default in TypeVar so Series defaults to Series[Any], and Index to Index[Any]default in TypeVar so Series defaults to Series[Any], and Index to Index[Any]
There was a problem hiding this comment.
thanks @MarcoGorelli . Nice new feature of typing to include.
|
yay, thanks! |
bit of an experiment
closes #1133
I saw that NumPy follow this pattern, for example here:
https://github.com/numpy/numpy/blob/3363b38d99f87601869c2c9d68c2b16e54509675/numpy/__init__.pyi#L788-L792
and they import
TypeVarfromtyping_extensions(which is a dependency of mypy anyway)This would close 1133 for free, and I think improve ergonomics